Fix a possible case when president receive a last vote after receiving a voted from someone else for the same ballot

This commit is contained in:
juju committed 2020-05-06 21:03:24 +02:00
1 parent 21dbc3e444
commit b33d2f17ab
2 files changed
+6 -3

No files matched your search

+4 -3
View File
@@ -10,13 +10,14 @@
namespace paxos
{
Legislator::Legislator(const LegislatorConfig& config)
: config_(config), ledger(config.name)
: config_(config), ledger(config.name), has_started(false)
{
log("created legislator " + config.name, blue);
}
void Legislator::initiate_ballot()
{
has_started = false;
quorum_previous_votes.clear();
int new_ballot_number = ledger.last_tried() + 1;
ledger.set_last_tried(new_ballot_number);
@@ -92,8 +93,7 @@ namespace paxos
int vote_decree = std::stoi(*message.get_header("decree"));
unsigned int nb_legislators = legislators.size();
if (ballot != ledger.last_tried()
|| quorum_previous_votes.size() > nb_legislators / 2)
if (ballot != ledger.last_tried() || has_started)
{
log("but it was discarded because ballot " + std::to_string(ballot)
+ " is outdated, it is either no longer in treatment or already started"
@@ -117,6 +117,7 @@ namespace paxos
void Legislator::receive_enough_last_vote()
{
has_started = true;
int ballot = ledger.last_tried();
std::string ballot_str = std::to_string(ballot);
+2
View File
@@ -40,8 +40,10 @@ namespace paxos
void handle_message(Message message);
private:
Ledger ledger;
std::unordered_map<std::string, Vote> quorum_previous_votes;
bool has_started;
};
using shared_legislator = std::shared_ptr<Legislator>;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.